Alternative congelation formulation following Plante et al. 2024 #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eclare108213
changed the title
dabail10
approved these changes
Jul 29, 2024
|
Will need some changes in Icepack documentation and maybe add a test case. Also need to update the icepack interface documentation (run ./icepack.setup --docintfc). CICE will also eventually need a new namelist added. |
|
See also CICE-Consortium/CICE#965 This PR and the CICE PR are ready to merge assuming we are happy leaving the old 'two-step' as the default. Please confirm that's how we want to proceed. We can always change the default later. |
|
I did do a fully-coupled test here with the one-step option and the solutions are quite different. Climate changing? Maybe not, but I think this is the correct way to go. We will definitely be using this in CESM3. |
dabail10
pushed a commit
to ESCOMP/Icepack
that referenced
this pull request
Aug 19, 2024
…E-Consortium#494) Add congel_freeze namelist and add 'one-step' option to the default 'two-step' option. Namelist flag congel_freeze chooses which formulation to use. The original is ‘two-step’, since only the mushy boundary moves in the first step and the phase change happens in the next step. Plante et al. (‘one-step’) moves the boundary and performs the phase change in a single time step. Maintain 'two-step' as default for now.
14 tasks
dabail10
pushed a commit
to ESCOMP/Icepack
that referenced
this pull request
Oct 25, 2024
…E-Consortium#494) Add congel_freeze namelist and add 'one-step' option to the default 'two-step' option. Namelist flag congel_freeze chooses which formulation to use. The original is ‘two-step’, since only the mushy boundary moves in the first step and the phase change happens in the next step. Plante et al. (‘one-step’) moves the boundary and performs the phase change in a single time step. Maintain 'two-step' as default for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for Plante et al. to confirm that these changes are all that are needed, separate from their flooding/snow-ice and forcing modifications. I still need to add tests to the test suite and update the Icepack documentation, then implement and test in CICE. Suggestions for better congel_freeze option labels are welcome.
I realigned some columns while working on this. Ignore white space when looking at diffs!
Add alternative congelation formulation following Plante et al., 2024.
@mathieuslplante et al., @eclare108213
congel_freeze = ‘two-step’is BFB in the base_suite -- this is currently the default (as before).congel_freeze = 'one-step'is not BFB. Settingconserv_check = .true.does not turn up any issues.A QC comparison for CICE PR #965 shows the differences between
congel_freeze = 'one-step'and'two-step'are not climate changing in CICE standalone simulations.congel_freeze = 'one-step'Namelist flag congel_freeze chooses which formulation to use. The original is ‘two-step’, since only the mushy boundary moves in the first step and the phase change happens in the next step. Plante et al. (‘one-step’) moves the boundary and performs the phase change in a single time step.
Closes #481